tools/update-go-azure-sdk: updating both the Base Layer and Resource Manager submodules
#24602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added a commit
to hashicorp/go-azure-sdk
that referenced
this pull request
Jan 23, 2024
This is needed as a part of hashicorp/pandora#3601 since we're going to be publishing multiple Go Modules at different paths - but the version number of each of them is going to be the same. As such this PR splits the determining and publishing of the Git Tag - such that the existing update tooling continues to work with minor changes (tracked in hashicorp/terraform-provider-azurerm#24602)
tombuildsstuff
force-pushed
the
f/updating-tooling-to-account-for-nested-go-modules
branch
from
42784c3 to
35d0443
Compare
tombuildsstuff
force-pushed
the
f/updating-tooling-to-account-for-nested-go-modules
branch
3 times, most recently
from
c232019 to
fade520
Compare
tombuildsstuff
commented
Jan 25, 2024
tombuildsstuff
force-pushed
the
f/updating-tooling-to-account-for-nested-go-modules
branch
from
fade520 to
b528825
Compare
…e Manager submodules Dependent on (and can't be fully tested until) hashicorp/pandora#3601 is rolled out.
tombuildsstuff
force-pushed
the
f/updating-tooling-to-account-for-nested-go-modules
branch
from
b528825 to
3f57f5a
Compare
tombuildsstuff
deleted the
f/updating-tooling-to-account-for-nested-go-modules
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also going to require changes to the Github Action in
hashicorp/go-azure-sdk(automation-release.yaml#L34) - where we're going to need to change how the Git Tag is determined, by pulling the latestsdk/tag (and then trimming off thesdk/prefix) to give us the version to update too, used by this tool.Dependent on #24636